Messages in this thread | | | Date | Mon, 13 Oct 2008 09:27:21 -0400 | From | Jeff Garzik <> | Subject | Re: [PATCH] pata_of_platform: fix no irq handling |
| |
Tejun Heo wrote: > Anton Vorontsov wrote: >> When no irq specified the pata_of_platform fills the irq_res with -1, >> which is wrong to do for two reasons: >> >> 1. By definition, 'no irq' should be IRQ 0, not some negative integer; >> 2. pata_platform checks for irq_res.start > 0, but since irq_res.start >> is unsigned type, the check will be true for `-1'. >> >> Reported-by: Steven A. Falco <sfalco@harris.com> >> Signed-off-by: Anton Vorontsov <avorontsov@ru.mvista.com> > > applied to #tj-upstream (will soon be sent upstream)
I have returned! muhahahahahaha....
| |