Messages in this thread Patch in this message | | | Date | Mon, 13 Oct 2008 12:03:03 +0200 | From | Andi Kleen <> | Subject | [PATCH] SYSFS: Fix return values for sysdev_store_{ulong,int} |
| |
SYSFS: Fix return values for sysdev_store_{ulong,int}
Always return the full size instead of the consumed length of the string in sysdev_store_{ulong,int}
This avoids EINVAL errors in some echo versions.
Signed-off-by: Andi Kleen <ak@linux.intel.com>
Index: linux/drivers/base/sys.c =================================================================== --- linux.orig/drivers/base/sys.c +++ linux/drivers/base/sys.c @@ -488,7 +488,8 @@ ssize_t sysdev_store_ulong(struct sys_de if (end == buf) return -EINVAL; *(unsigned long *)(ea->var) = new; - return end - buf; + /* Always return full write size even if we didn't consume all */ + return size; } EXPORT_SYMBOL_GPL(sysdev_store_ulong); @@ -511,7 +512,8 @@ ssize_t sysdev_store_int(struct sys_devi if (end == buf || new > INT_MAX || new < INT_MIN) return -EINVAL; *(int *)(ea->var) = new; - return end - buf; + /* Always return full write size even if we didn't consume all */ + return size; } EXPORT_SYMBOL_GPL(sysdev_store_int);
| |