lkml.org 
[lkml]   [2008]   [Oct]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 1/1] netdev: DM9000: Added typecasting to supress some warnings on Blackfin
On Mon, Oct 13, 2008 at 5:17 PM, Ben Dooks <ben-linux@fluff.org> wrote:
> On Mon, Oct 13, 2008 at 05:10:09PM +0800, Bryan Wu wrote:
>> From: Javier Herrero <jherrero@hvsistemas.es>
>
> No, your arch definitions of writesb and co are wrong if they
> are not taking 'void __iomem *' arguments.
>

Right, we should check the I/O functions and make them support "void
__iomem *" arguments.

Thanks
-Bryan

>> Signed-off-by: Javier Herrero <jherrero@hvsistemas.es>
>> Signed-off-by: Bryan Wu <cooloney@kernel.org>
>> ---
>> drivers/net/dm9000.c | 12 ++++++------
>> 1 files changed, 6 insertions(+), 6 deletions(-)
>>
>> diff --git a/drivers/net/dm9000.c b/drivers/net/dm9000.c
>> index f42c23f..c4737ca 100644
>> --- a/drivers/net/dm9000.c
>> +++ b/drivers/net/dm9000.c
>> @@ -188,35 +188,35 @@ iow(board_info_t * db, int reg, int value)
>>
>> static void dm9000_outblk_8bit(void __iomem *reg, void *data, int count)
>> {
>> - writesb(reg, data, count);
>> + writesb((int)reg, data, count);
>> }
>>
>> static void dm9000_outblk_16bit(void __iomem *reg, void *data, int count)
>> {
>> - writesw(reg, data, (count+1) >> 1);
>> + writesw((int)reg, data, (count+1) >> 1);
>> }
>>
>> static void dm9000_outblk_32bit(void __iomem *reg, void *data, int count)
>> {
>> - writesl(reg, data, (count+3) >> 2);
>> + writesl((int)reg, data, (count+3) >> 2);
>> }
>>
>> /* input block from chip to memory */
>>
>> static void dm9000_inblk_8bit(void __iomem *reg, void *data, int count)
>> {
>> - readsb(reg, data, count);
>> + readsb((int)reg, data, count);
>> }
>>
>>
>> static void dm9000_inblk_16bit(void __iomem *reg, void *data, int count)
>> {
>> - readsw(reg, data, (count+1) >> 1);
>> + readsw((int)reg, data, (count+1) >> 1);
>> }
>>
>> static void dm9000_inblk_32bit(void __iomem *reg, void *data, int count)
>> {
>> - readsl(reg, data, (count+3) >> 2);
>> + readsl((int)reg, data, (count+3) >> 2);
>> }
>>
>> /* dump block from chip to null */
>> --
>> 1.5.6
>
> --
> --
> Ben
>
> Q: What's a light-year?
> A: One-third less calories than a regular year.
>
>


\
 
 \ /
  Last update: 2008-10-13 12:13    [W:0.085 / U:2.032 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site