lkml.org 
[lkml]   [2008]   [Oct]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 23/80] nozomi: Fix close on error
    Date
    From: Alan Cox <alan@redhat.com>

    Nozomi assumes the close method isn't called if open errors. The tty layer
    is different to other drives in this respect however. Pointed out by Denis J
    Barrow.

    Signed-off-by: Alan Cox <alan@redhat.com>
    ---

    drivers/char/nozomi.c | 5 ++++-
    1 files changed, 4 insertions(+), 1 deletions(-)


    diff --git a/drivers/char/nozomi.c b/drivers/char/nozomi.c
    index 66a0f93..9a34a19 100644
    --- a/drivers/char/nozomi.c
    +++ b/drivers/char/nozomi.c
    @@ -1599,7 +1599,10 @@ static int ntty_open(struct tty_struct *tty, struct file *file)
    return 0;
    }

    -/* Called when the userspace process close the tty, /dev/noz*. */
    +/* Called when the userspace process close the tty, /dev/noz*. Also
    + called immediately if ntty_open fails in which case tty->driver_data
    + will be NULL an we exit by the first return */
    +
    static void ntty_close(struct tty_struct *tty, struct file *file)
    {
    struct nozomi *dc = get_dc_by_tty(tty);


    \
     
     \ /
      Last update: 2008-10-13 11:43    [W:0.061 / U:150.148 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site