lkml.org 
[lkml]   [2008]   [Oct]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 1/4] Add support for userspace stacktraces in tracing/iter_ctrl
    2008/10/12 Török Edwin <edwintorok@gmail.com>:
    > +static int copy_stack_frame(const void __user *fp, struct stack_frame *frame)
    > +{
    > + int ret;
    > +
    > + if (!access_ok(VERIFY_READ, fp, sizeof(*frame)))
    > + return 0;
    > +
    > + ret = 1;
    > + pagefault_disable();
    > + if (__copy_from_user_inatomic(frame, fp, sizeof(*frame)))
    > + ret = 0;
    > + pagefault_enable();
    > +
    > + return ret;
    > +}
    > +

    Hello Török,

    I don't understand why you are using this pagefault disabling and
    atomic copy here.
    Wouldn't a simple copy_from_user actually take of this? You don't seem
    to be in atomic
    context.
    --
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2008-10-12 15:35    [W:0.021 / U:120.940 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site