Messages in this thread | | | Date | Sat, 11 Oct 2008 12:20:50 +0800 | From | Franko Fang <> | Subject | Re: PATCH 10/8]linux-usb: To support more Huawei data card productIDs, fix kernel 2.6.27-rc7 |
| |
Dear Greg and Alan,
Well, OK, but I will change it as follows:
result = usb_stor_control_msg(us, us->send_ctrl_pipe, USB_REQ_SET_FEATURE, USB_TYPE_STANDARD | USB_RECIP_DEVICE, 0x01, 0x0, NULL, 0x0, 1000);
Because the parameters of USB_REQ_SET_FEATURE, USB_TYPE_STANDARD and USB_RECIP_DEVICE are all Hex, so I want to keep my other parameters to be consistant with them. And I see the same using with me in the kernel. Such as the code of the function usb_stor_euscsi_init in initializers.c file.
Is this changing can be accepted by you?
If so, I will resubmit the new patch as soon as possible.
Hope for your reply soon.
Thanks.
The original codes are: us->iobuf[0] = 0x1; result = usb_stor_control_msg(us, us->send_ctrl_pipe, USB_REQ_SET_FEATURE, USB_TYPE_STANDARD | USB_RECIP_DEVICE, 0x01, 0x0, us->iobuf, 0x1, 1000);
Best Regards,
Franko Fang 2008-10-11
----- Original Message ----- From: "Greg KH" <greg@kroah.com> To: "fangxiaozhi 00110321" <huananhu@huawei.com> Cc: <linux-usb@vger.kernel.org>; <linux-kernel@vger.kernel.org>; <zihan@huawei.com>; <zhangqianchun@huawei.com> Sent: Saturday, October 11, 2008 5:15 AM Subject: Re: PATCH 10/8]linux-usb: To support more Huawei data card productIDs, fix kernel 2.6.27-rc7
> On Wed, Oct 08, 2008 at 12:02:46PM +0800, fangxiaozhi 00110321 wrote: >> From: fangxiaozhi <huananhu@huawei.com> >> >> 1. This patch is based on the kernel of 2.6.27-rc7 >> 2. In this patch, we want to do one thing: add more Huawei product IDs into the USB driver. Then it can support more Huawei data card devices. So to declare the unusual device for new Huawei data card devices >> in unusual_devs.h and to declare more new product IDs in option.c. >> 3. To modify the data value and length in the function of >> usb_stor_huawei_e220_init in initializers.c >> That's because based on the USB standard, while sending SET_FETURE_D to the device, it requires the corresponding data to be zero, and its sending length also must be zero. >> In our old solution, it can be compatible with our WCDMA data card devices, but can not support our CDMA data card devices. >> But in this new solution, it can be compatible with all of our data card devices. > > Can you make the changes Alan suggested? > > I'll hold off for a new version after you have integrated that change. > > thanks, > > greg k-h
| |