lkml.org 
[lkml]   [2008]   [Oct]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH -mm -v5] Separate atomic_t declaration from asm/atomic.h into asm/atomic_def.h
    On Fri, 10 Oct 2008 23:49:58 +0200
    Ingo Molnar <mingo@elte.hu> wrote:

    >
    > * Andrew Morton <akpm@linux-foundation.org> wrote:
    >
    > > On Wed, 08 Oct 2008 17:44:30 +0800
    > > Huang Ying <ying.huang@intel.com> wrote:
    > >
    > > > From: Huang Ying <ying.huang@intel.com>
    > > >
    > > > asm/atomic.h contains both declaration and implementation of atomic_t. So
    > > > there are some implementation related files included in asm/atomic.h. And
    > > > atomic_t is a typedef. Combination of above makes it impossible to use
    > > > atomic_t in files included by atomic.h. Such as atomic_t can not be used
    > > > in linux/kernel.h on i386, because it is included by asm/atomic.h.
    > > >
    > > > It is reasonable to separate declaration from implementation. So a new
    > > > file atomic_types.h is added for every architecture to accommodate the
    > > > declaration of atomic_t.
    > > >
    > > > Includes fixes from Andrew Moton.
    > > >
    > > > Signed-off-by: Huang Ying <ying.huang@intel.com>
    > > > Reviewed-by: Ingo Molnar <mingo@elte.hu>
    > >
    > > The difference between what-i-currently-have and what-you-just-sent is
    > > below. It's quite large.
    > >
    > > Can you explain this update please?
    >
    > i've been giving review feedback to make it all fit into existing
    > namespace concepts better. Should have no change in functionality. (But
    > i have not tested it)
    >

    I have a note here that Matthew has proposed a different way of doing
    all this. I don't immediately recall the details.

    Can we get a refresh on all of that please?


    \
     
     \ /
      Last update: 2008-10-11 00:59    [W:0.031 / U:0.572 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site