Messages in this thread | | | Date | Sat, 11 Oct 2008 09:15:08 +1100 (EST) | From | James Morris <> | Subject | Re: [PATCH 0/4] integrity |
| |
On Fri, 10 Oct 2008, Mimi Zohar wrote:
> > > These TPM patches are base TPM changes, not really related to the > > > integrity patches and certainly not dependent them. However the reverse > > > is not true. The integrity-tpm-internal-kernel-interface patch is > > > dependent on, at least, the TPM-rcu-locking patch. > > > > Please repost the TPM patches, then. > > The TPM patches were just added to the -mm tree (10/8 18:45 EDT), > available from http://userweb.kernel.org/~akpm/mmotm/.
I've added the prereq patches to git://git.kernel.org/pub/scm/linux/kernel/git/jmorris/security-testing-2.6#next
Please test it, and base your next version of the integrity patches on that branch. Generally, if your patches depend on some other patches, you need to coordinate to ensure the prerequisite patches are either in the tree you're aiming for, or post them as part of the patchset.
Note that there are some interesting sparse warnings for the TPM code (not arising from the above):
drivers/char/tpm/tpm.c:493:10: error: bad constant expression drivers/char/tpm/tpm.c:500:32: error: cannot size expression drivers/char/tpm/tpm.c:507:10: error: bad constant expression drivers/char/tpm/tpm.c:515:32: error: cannot size expression drivers/char/tpm/tpm.c:547:32: error: cannot size expression CHECK drivers/char/tpm/tpm_atmel.c CHECK drivers/char/tpm/tpm_infineon.c drivers/char/tpm/tpm_bios.c:412:7: warning: incorrect type in assignment (different address spaces) drivers/char/tpm/tpm_bios.c:412:7: expected struct acpi_table_header *virt drivers/char/tpm/tpm_bios.c:412:7: got void [noderef] <asn:2>* drivers/char/tpm/tpm_bios.c:416:23: warning: incorrect type in argument 1 (different address spaces) drivers/char/tpm/tpm_bios.c:416:23: expected void [noderef] <asn:2>*logical_address drivers/char/tpm/tpm_bios.c:416:23: got struct acpi_table_header *virt
-- James Morris <jmorris@namei.org>
| |