Messages in this thread | | | Date | Fri, 10 Oct 2008 16:58:14 +0200 | From | Haavard Skinnemoen <> | Subject | Re: [PATCH] Make ATNGW100 serial ports configurable |
| |
Anders Blomdell <anders.blomdell@control.lth.se> wrote: > Make configuration of ATNGW100 serial ports selectable in kernel configuration. > > Signed-off-by: Anders Blomdell <anders.blomdell@control.lth.se>
Gak. If we're going down this path, why not add #ifdefs for every other conceivable hardware mod as well and turn the ATNGW100 board code into an even worse mess than the ATSTK1000 board code?
The ATNGW100 has one serial port on board, so IMO the standard board code should only initialize that one port.
However, it might be sensible to add some sort of interface for expansion board code. For example something like this:
#ifdef CONFIG_ATNGW100_EXPANSION atngw100_setup_expansion_board(); #endif
This will allow people with hardware mods to add all the extra devices they need, including serial ports, by simply adding another file with expansion board code. People who aren't afraid to solder stuff on their boards shouldn't be afraid of writing some board code too, right?
What do you think?
Haavard
| |