Messages in this thread Patch in this message | | | Date | Fri, 10 Oct 2008 16:38:38 +0400 | From | Cyrill Gorcunov <> | Subject | Re: [PATCH] Typo in x86 apic.c with DIVISOR setup |
| |
[Ingo Molnar - Fri, Oct 10, 2008 at 01:56:55PM +0200] | | * Maciej W. Rozycki <macro@linux-mips.org> wrote: | | > On Fri, 10 Oct 2008, Cyrill Gorcunov wrote: | > | > > Btw I don't remember but hope it was not me who made this typo -- | > | > What would be the difference so that you hope it wasn't you? All the | > people make mistakes, this one has been caught and that's what really | > matters. | | yeah, like most kernel newbies Cyrill is worrying way too much about | mistakes. In 10 years time he too will have his healthy collection of | embarrassing brown paperbag incidents and will be a lot more relaxed | about it, just like the rest of us ;-) | | what matters is to fix them quickly and to learn from those mistakes | that are avoidable. | | Ingo |
Just brought first paperbag -- usefull thing I've to say :) ...
ok, what the conclusion will be on divisor side? I think something like that maybe. Maciej?
- Cyrill -
---
Index: linux-2.6.git/arch/x86/kernel/apic.c =================================================================== --- linux-2.6.git.orig/arch/x86/kernel/apic.c 2008-09-26 20:43:47.000000000 +0400 +++ linux-2.6.git/arch/x86/kernel/apic.c 2008-10-10 16:37:26.000000000 +0400 @@ -332,11 +332,7 @@ int lapic_get_maxlvt(void) */ /* Clock divisor */ -#ifdef CONFG_X86_64 -#define APIC_DIVISOR 1 -#else #define APIC_DIVISOR 16 -#endif /* * This function sets up the local APIC timer, with a timeout of @@ -592,10 +588,10 @@ static int __init calibrate_APIC_clock(v global_clock_event->event_handler = lapic_cal_handler; /* - * Setup the APIC counter to 1e9. There is no way the lapic + * Setup the APIC counter to maximum. There is no way the lapic * can underflow in the 100ms detection time frame */ - __setup_APIC_LVTT(1000000000, 0, 0); + __setup_APIC_LVTT(0xffffffff, 0, 0); /* Let the interrupts run */ local_irq_enable();
| |