lkml.org 
[lkml]   [2008]   [Oct]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 27/27] serial_8250: pci_enable_device fail is not fully handled
    Date
    <rmk> talking about leaks - I noticed that the 'check return of
    pci_enable_dev()' in the 8250 pci resume function finally made it in,
    inspite my objections against it (causing stuff in higher levels to leak).

    Signed-off-by: Alan Cox <alan@redhat.com>
    ---

    drivers/serial/8250_pci.c | 4 ++--
    1 files changed, 2 insertions(+), 2 deletions(-)

    diff --git a/drivers/serial/8250_pci.c b/drivers/serial/8250_pci.c
    index c2f2393..c014ffb 100644
    --- a/drivers/serial/8250_pci.c
    +++ b/drivers/serial/8250_pci.c
    @@ -2041,9 +2041,9 @@ static int pciserial_resume_one(struct pci_dev *dev)
    * The device may have been disabled. Re-enable it.
    */
    err = pci_enable_device(dev);
    + /* FIXME: We cannot simply error out here */
    if (err)
    - return err;
    -
    + printk(KERN_ERR "pciserial: Unable to re-enable ports, trying to continue.\n");
    pciserial_resume_ports(priv);
    }
    return 0;


    \
     
     \ /
      Last update: 2008-10-10 12:59    [W:0.019 / U:59.208 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site