lkml.org 
[lkml]   [2008]   [Oct]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH v3 00/14] PCI: let the core manage slot names
    Hi Taku-san,

    * Taku Izumi <izumi.taku@jp.fujitsu.com>:
    >> This series applies against linux-next. I've tested this by loading
    >> pci_slot and various hotplug drivers to ensure that the hotplug drivers
    >> can successfully override the pci_slot names.
    >
    > It seems that there are some bugs. Pciehp and shpchp modules can not
    > be loaded when the debug option is specified. Segmentation fault occurs
    > with stack dump.
    >
    > pciehp_probe() or shpchp_probe()
    > -> init_slots()
    > -> get_power_status()
    > -> slot_name() : This is called when the debug option is specified.
    > -> hotplug_slot_name()
    > -> pci_slot_name(slot->pci_slot)
    > ~~~~~~~~~~~~~~
    > Not initialized yet.

    Thank you for pointing this out. I've fixed this (and the other
    drivers) by make sure that the slot names are initialized before
    we attempt to use them.

    Trying to fix rpaphp was too much work for very little gain, so I
    deleted that patch from my patch series. But the changes to the
    hotplug core still make sense, so it's ok to have just one
    oddball left.

    I'll wait until Kenji-san sends out his final review comments
    before sending out v4.

    Thanks.

    /ac



    \
     
     \ /
      Last update: 2008-10-01 23:07    [W:4.211 / U:0.416 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site