lkml.org 
[lkml]   [2008]   [Oct]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
DateWed, 1 Oct 2008 19:42:36 +0200
FromIngo Molnar <>
SubjectRe: [PATCH] ftrace: type cast verifier

* Steven Rostedt <rostedt@goodmis.org> wrote:

> +#define FTRACE_CMP_TYPE(var, type) \
> + __builtin_types_compatible_p(typeof(var), type *)

ah, the -rt type trick ;-)

i'd suggest one more small detail:

> + struct trace_mmiotrace_map *field;
> + struct mmiotrace_map *m;

> + trace_assign_type(field, entry);

could you rename it to trace_type() - that way the initialization could
be written in a more compact way as:

> + struct trace_mmiotrace_map *field = trace_type(field, entry);

[ NOTE: there's namespace clash with a local symbol in ./trace_irqsoff.c
and a trace_type enum as well ]

Ingo


\
 
 \ /
  Last update: 2008-10-01 19:45    [from the cache]
©2003-2010