lkml.org 
[lkml]   [2008]   [Oct]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH] pci: introduce users of ioremap_pcibar()
    On Tue, Sep 30, 2008 at 03:30:01PM -0700, Arjan van de Ven wrote:
    > On Tue, 30 Sep 2008 23:24:50 -0600
    > Grant Grundler <grundler@parisc-linux.org> wrote:
    >
    > >
    > > > And pci_iomap() takes more parameters than most driver writers want
    > > > or need. Most of the time it's "I want the whole bar"; even if my
    > > > patch wraps around that, making the API simpler is still worth it
    > > > imo
    > >
    > > You are right about that.
    > > Would calling the API "pci_iomap_bar()" to keep the naming consistent
    > > help make it more acceptable?
    >
    > I'm fine with pci_iomap_bar()... it meets my goals
    > Would be nice if I'd be allowed to make it only work on MEM bars not IO
    > bars (so that drivers don't accidentally end up calling this on an IO
    > bar and then using readl() etc)
    >

    If they use the iomap interface they shouldn't be using readl at all,
    they should be using ioread*... It would be a bug otherwise.

    cheers, Kyle


    \
     
     \ /
      Last update: 2008-10-01 14:45    [W:0.020 / U:0.416 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site