Messages in this thread |  | | | From | Junio C Hamano <> | | Subject | Re: [JANITOR PROPOSAL] Switch ioctl functions to ->unlocked_ioctl | | Date | Wed, 09 Jan 2008 02:00:21 -0800 |
| |
Andi Kleen <andi@firstfloor.org> writes:
> I imagined it would check for > > +struct file_operations ... = { > + ... > + .ioctl = ... > > That wouldn't catch the case of someone adding only .ioctl to an > already existing file_operations which is not visible in the patch context, > but that should be hopefully rare. The more common case is adding > completely new operations.
Because "diff -p" format used by the kernel mailing list takes the most recent line that begins with an identifier letter and put that on the hunk header line, even in such a case, you will see:
@@ -l,k +m,n @@ struct file_operations ... = { ... ... + ... + .ioctl = ... + ... ... which would be a good enough cue that the new .ioctl member is added to file_operations.
|  |