Messages in this thread | | | Date | Thu, 10 Jan 2008 13:23:16 +0900 | From | KAMEZAWA Hiroyuki <> | Subject | Re: [patch 05/19] split LRU lists into anon & file sets |
| |
On Thu, 10 Jan 2008 08:56:31 +0530 Balbir Singh <balbir@linux.vnet.ibm.com> wrote:
> > > The control_type feature is gone. We still have cached page > > > accounting, but we do not allow control of only RSS pages anymore. We > > > need to control both RSS+cached pages. I do not understand your > > > question about new plan? Is it about adding back control_type? > > > > > Ah, just wanted to confirm that we can drop PAGE_CGROUP_FLAG_CACHE > > if page_file_cache() function and split-LRU is introduced. > > > > Earlier we would have had a problem, since we even accounted for swap > cache with PAGE_CGROUP_FLAG_CACHE and I think page_file_cache() does > not account swap cache pages with page_file_cache(). Our accounting > is based on mapped vs unmapped whereas the new code from Rik accounts > file vs anonymous. I suspect we could live a little while longer > with PAGE_CGROUP_FLAG_CACHE and then if we do not need it at all, > we can mark it down for removal. What do you think?
Okay, I have no objection.
Thanks, -Kame
| |