lkml.org 
[lkml]   [2008]   [Jan]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] Kprobes: Add kprobes smoke tests that run on boot
On Wed, Jan 09, 2008 at 08:00:03AM +0000, Christoph Hellwig wrote:
> On Tue, Jan 08, 2008 at 11:18:02PM +0100, Ingo Molnar wrote:
> >
> > * Andi Kleen <andi@firstfloor.org> wrote:
> >
> > > Ananth N Mavinakayanahalli <ananth@in.ibm.com> writes:
> > > > kernel/kprobes.c | 2
> > > > kernel/test_kprobes.c | 216 ++++++++++++++++++++++++++++++++++++++++++++++++
> > >
> > > Can you put this somewhere else please? I know there are already some
> > > test files in kernel/* but imho they all belong into some other
> > > directory.
> >
> > agreed - lib/* would be the right place i think - we've got
> > lib/locking-selftest.c already.
>
> Actually the right place would be to have a separate toplevel directory
> I think, and a separate menu in the kernel config machinery. Thay way
> tests are in one place and easily spottable.

Seconded...

Sam


\
 
 \ /
  Last update: 2008-01-09 09:11    [W:0.080 / U:0.400 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site