Messages in this thread | | | Date | Wed, 09 Jan 2008 22:15:42 -0500 | From | Masami Hiramatsu <> | Subject | Re: [PATCH 2/2] kprobe: remove preempt_enable/disable from kprobe_handle_fault() |
| |
Harvey Harrison wrote: > This patch removes the preempt_disable/enable pair around kprobe_running > which was originally added to avoid the assertion from smp_processor_id > which would be hit an asertion if preemption was enabled. > > Kprobes can not be running if we are preemptible, so test explicitly > for preemption and bail out before hitting kprobe_running(). > > Signed-off-by: Harvey Harrison <harvey.harrison@gmail.com>
Tested on x86-64.
Acked-by: Masami Hiramatsu <mhiramat@redhat.com>
Thank you!
-- Masami Hiramatsu
Software Engineer Hitachi Computer Products (America) Inc. Software Solutions Division
e-mail: mhiramat@redhat.com, masami.hiramatsu.pt@hitachi.com
| |