Messages in this thread | | | Date | Wed, 9 Jan 2008 11:19:01 -0800 (PST) | From | Christoph Lameter <> | Subject | Re: [PATCH] x86_64: cleanup setup_node_zones called by paging_init v2 |
| |
On Wed, 9 Jan 2008, Yinghai Lu wrote:
> +#ifdef CONFIG_FLAT_NODE_MEM_MAP > /* Initialize final allocator for a zone */ > -void __init setup_node_zones(int nodeid) > +static void __init setup_node_zones(int nodeid) > { > unsigned long start_pfn, end_pfn, memmapsize, limit; > > @@ -244,14 +245,14 @@ void __init setup_node_zones(int nodeid) > memory. */ > memmapsize = sizeof(struct page) * (end_pfn-start_pfn); > limit = end_pfn << PAGE_SHIFT; > -#ifdef CONFIG_FLAT_NODE_MEM_MAP > + > NODE_DATA(nodeid)->node_mem_map = > __alloc_bootmem_core(NODE_DATA(nodeid)->bdata, > memmapsize, SMP_CACHE_BYTES, > round_down(limit - memmapsize, PAGE_SIZE), > limit); > -#endif > }
Here you could do an
#else
<empty def of setup_node_zones>
which would avoid the additional #ifdef later.
Also move the for_each statement into that function.
The current version will have an unused variable i if CONFIG_FLAG_NODE_MEM_MAP is not set.
| |