Messages in this thread |  | | | Date | Tue, 8 Jan 2008 11:07:25 +0530 | | From | Ananth N Mavinakayanahalli <> | | Subject | Re: [PATCHv2] kprobes: Introduce is_kprobe_fault() | |
On Mon, Jan 07, 2008 at 12:24:46PM -0800, Harvey Harrison wrote:
> Use a central is_kprobe_fault() inline in kprobes.h to remove all
> of the arch-dependant, practically identical implementations in
> avr32, ia64, powerpc, s390, sparc64, and x86.
>
> avr32 was the only arch without the preempt_disable/enable pair
> in its notify_page_fault implementation.
>
> This uncovered a possible bug in the s390 version as that purely
> copied the x86 version unconditionally passing 14 as the trapnr
> rather than the error_code parameter.
>
> Signed-off-by: Harvey Harrison <harvey.harrison@gmail.com>
Tested on powerpc.
Tested-by: Ananth N Mavinakayanahalli <ananth@in.ibm.com>
|  |