lkml.org 
[lkml]   [2008]   [Jan]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 00 of 10] x86: unify asm/pgtable.h

    > >>> #define __PAGE_KERNEL_EXEC \
    > >>> - (_PAGE_PRESENT | _PAGE_RW | _PAGE_DIRTY | _PAGE_ACCESSED | _PAGE_GLOBAL)
    > >>> + (_PAGE_PRESENT | _PAGE_RW | _PAGE_DIRTY | _PAGE_ACCESSED)
    > >>>
    > >
    > > This shouldn't be necessary. The old 64-bit code defined everything
    > > without _PAGE_GLOBAL, but then used a MAKE_GLOBAL() macro to OR it
    > > in later. This seemed a bit roundabout to me, so I just put it in
    > > from the outset.

    actually, this is wrong.

    a couple of places use __PAGE_* values, which you've now changed to
    include the _PAGE_GLOBAL flag.

    Ingo


    \
     
     \ /
      Last update: 2008-01-09 01:31    [W:0.047 / U:0.112 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site