lkml.org 
[lkml]   [2008]   [Jan]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 00 of 10] x86: unify asm/pgtable.h
    Ingo Molnar wrote:
    > * Ingo Molnar <mingo@elte.hu> wrote:
    >
    >
    >> #define __PAGE_KERNEL_EXEC \
    >> - (_PAGE_PRESENT | _PAGE_RW | _PAGE_DIRTY | _PAGE_ACCESSED | _PAGE_GLOBAL)
    >> + (_PAGE_PRESENT | _PAGE_RW | _PAGE_DIRTY | _PAGE_ACCESSED)
    >>

    This shouldn't be necessary. The old 64-bit code defined everything
    without _PAGE_GLOBAL, but then used a MAKE_GLOBAL() macro to OR it in
    later. This seemed a bit roundabout to me, so I just put it in from the
    outset.

    > btw., __PAGE_KERNEL_EXEC should probably be _PAGE_GLOBAL - but it wasnt
    > before.
    >

    You mean _PAGE_KERNEL_EXEC, which is assigned to the 32-bit
    __PAGE_KERNEL_EXEC variable? It gets ORed in when it determines that
    the processor has the global capability.

    If not, I'm not sure what you mean.

    J


    \
     
     \ /
      Last update: 2008-01-09 01:17    [W:0.020 / U:9.640 seconds]
    ©2003-2017 Jasper Spaans. hosted at Digital OceanAdvertise on this site