Messages in this thread | | | Date | Tue, 8 Jan 2008 14:47:02 -0800 | From | Andrew Morton <> | Subject | Re: [PATCH] eCryptfs: Load each file decryption key only once |
| |
On Tue, 8 Jan 2008 15:17:33 -0600 Michael Halcrow <mhalcrow@us.ibm.com> wrote:
> On Fri, Dec 21, 2007 at 08:05:30PM -0600, Trevor Highland wrote: > > eCryptfs: Load each file decryption key only once > > > > There is no need to keep re-setting the same key for any given > > eCryptfs inode. This patch optimizes the use of the crypto API and > > helps performance a bit. > > There is no reason for the crypt_stat->key value for any given > eCryptfs inode to change during the life of the inode, and each > crypt_stat gets its own crypto transform, so I do not see a problem > with Trevor's suggestion. It will save unnecessary calls to > crypto_blkcipher_setkey(), and I expect it will speed things up a > little. > > I include an updated patch against 2.6.24-rc7. >
Your new patch clashes horridly with the pending ecryptfs-set-inode-key-only-once-per-crypto-operation.patch.
I shall drop ecryptfs-load-each-file-decryption-key-only-once.patch and shall then sit back and sulk.
| |