Messages in this thread | | | Date | Wed, 9 Jan 2008 09:45:59 +1100 | From | Paul Mackerras <> | Subject | Re: [PATCHv2] kprobes: Introduce is_kprobe_fault() |
| |
Harvey Harrison writes:
> Use a central is_kprobe_fault() inline in kprobes.h to remove all > of the arch-dependant, practically identical implementations in > avr32, ia64, powerpc, s390, sparc64, and x86.
I don't like the name "is_kprobe_fault" since the function actually handles the fault - i.e. it does more than just tell the caller whether this is a kprobes fault. Something like "handle_kprobes_fault" or "maybe_handle_kprobes_fault" would be better IMO.
Paul.
| |