lkml.org 
[lkml]   [2008]   [Jan]   [8]   [last100]   RSS Feed
Views: [more markup]  [less markup]  [headers]  [forward] 
 
Messages in this thread
/
DateTue, 8 Jan 2008 09:04:19 +0100
FromIngo Molnar <>
SubjectRe: [PATCH] x86_64: enable irq in default_idle
* Hiroshi Shimamoto <h-shimamoto@ct.jp.nec.com> wrote:

> Hi Ingo,> > I think local_irq_enable() is missing in default_idle() on x86_64. 
> It's for recent x86 tree.> > From: Hiroshi Shimamoto <h-shimamoto@ct.jp.nec.com>
> Subject: [PATCH] x86_64: enable irq in default_idle
> 
> local_irq_enable() is missing after sched_clock_idle_wakeup_event().

thanks Hiroshi, applied.

The effects of this bug should be increased latencies on 64-bit. Did you 
notice these latencies, or did you find the bug in some other way (code 
review)?

	Ingo


\
 
 \ /
  Last update: 2008-01-08 09:07    [from the cache]
©2003-2008