lkml.org 
[lkml]   [2008]   [Jan]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    SubjectRe: [PATCH] DS1WM: decouple host IRQ and INTR active state settings.
    From
    Date
    On Mon, 2008-01-07 at 15:10 -0800, Andrew Morton wrote:
    > On Sun, 06 Jan 2008 14:46:14 +0100
    > Philipp Zabel <philipp.zabel@gmail.com> wrote:
    >
    > > The DS1WM driver incorrectly infers the IAS bit (1-wire interrupt active
    > > high) from IRQ settings. There are devices that have IAS=0 but still need
    > > the IRQ to trigger on a rising edge. With this patch, machines with DS1WM
    > > that need IAS=1 have to set .active_high=1 in the ds1wm_platform_data.

    > But no drivers are converted to set ds1wm_platform_data.active_high. Won't
    > IORESOURCE_IRQ_HIGHEDGE devices be broken by this change?

    Good point; I think you're right. I'd guess the other platforms that use
    this driver are in the handhelds.org tree, but I've been out of the loop
    a while. Philipp, is this the case?

    Matt



    \
     
     \ /
      Last update: 2008-01-08 01:17    [W:0.021 / U:29.728 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site