Messages in this thread | | | Date | Mon, 7 Jan 2008 20:19:18 +0100 | From | Marcin Slusarz <> | Subject | Re: [PATCH 19/24] udf: check if udf_load_logicalvol failed |
| |
On Mon, Jan 07, 2008 at 12:29:51PM +0100, Jan Kara wrote: > On Sun 23-12-07 02:51:09, marcin.slusarz@gmail.com wrote: > > udf_load_logicalvol may fail eg in out of memory conditions - check it > > and propagate error further > > > > Signed-off-by: Marcin Slusarz <marcin.slusarz@gmail.com> > > CC: Ben Fennema <bfennema@falcon.csc.calpoly.edu> > > CC: Jan Kara <jack@suse.cz> > I certainly agree with the idea of the change. Just note that > udf_process_sequence() returns 1 in case of failure so propagating an error > is not ideal - we should keep things consistent. And also note that the > actual value is disregarded in udf_load_partition() anyway. OK, I will make it consistent in next version.
Marcin
| |