Messages in this thread |  | | | Date | Sun, 6 Jan 2008 08:46:20 -0600 | | From | Olof Johansson <> | | Subject | Re: [patch 5/5] PowerPC: switch to generic WARN_ON / BUG_ON |
| |
On Sun, Jan 06, 2008 at 10:16:04PM +1100, Benjamin Herrenschmidt wrote: > > On Sat, 2008-01-05 at 19:12 -0800, Arjan van de Ven wrote: > > From: Olof Johansson <olof@lixom.net> > > > > Not using the ppc-specific WARN_ON/BUG_ON constructs actually saves about > > 4K text on a ppc64_defconfig. The main reason seems to be that prepping > > the arguments to the conditional trap instructions is more work than just > > doing a compare and branch. > > I'm a bit annoyed by that one ... for obvious reasons... I wish gcc > could be better here. Also, we can't completely remove the support for > the trap since we use that in asm in various places...
The support isn't removed, and the trap is still used. This patch has been posted a bunch of times before and been in -mm for quite a while.
-Olof
|  |