lkml.org 
[lkml]   [2008]   [Jan]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [patch 5/5] PowerPC: switch to generic WARN_ON / BUG_ON
    On Sun, Jan 06, 2008 at 10:16:04PM +1100, Benjamin Herrenschmidt wrote:
    >
    > On Sat, 2008-01-05 at 19:12 -0800, Arjan van de Ven wrote:
    > > From: Olof Johansson <olof@lixom.net>
    > >
    > > Not using the ppc-specific WARN_ON/BUG_ON constructs actually saves about
    > > 4K text on a ppc64_defconfig. The main reason seems to be that prepping
    > > the arguments to the conditional trap instructions is more work than just
    > > doing a compare and branch.
    >
    > I'm a bit annoyed by that one ... for obvious reasons... I wish gcc
    > could be better here. Also, we can't completely remove the support for
    > the trap since we use that in asm in various places...

    The support isn't removed, and the trap is still used. This patch has
    been posted a bunch of times before and been in -mm for quite a while.


    -Olof



    \
     
     \ /
      Last update: 2008-01-06 15:41    [W:0.037 / U:186.732 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site