lkml.org 
[lkml]   [2008]   [Jan]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    SubjectRe: [linux-pm][PATCH] base: Change power/wakeup output from "" to "unsupported" if wakeup feature isn't supported by a device
    From
    Date
    On Fri, 2008-01-04 at 08:31 -0800, David Brownell wrote:
    > > This patch changes empty output to "unsupported" in order that a user knows
    > > wakeup feature isn't supported by this device when he/she
    > > 'cat /sys/devices/.../power/wakeup', please consider to apply, thanks.
    >
    > I don't much like this patch. Not just for the technical reasons
    > mentioned in my previous note ... but also because it doesn't update
    > the documention at the top, which clearly states that "\n" is
    > returned for "temporary or permanent inability to issue wakeup".
    > And then it gives the example I gave before ...
    >
    > Though I suppose a patch that changes the *entire* userspace interface,
    > (which includes its documentation, and all out-of-tree users) would have
    > shown more clearly why it wasn't a good idea. ;)
    Really, "\n" should be changed to show that change.
    Anyway, "\n" isn't a good indicator for that state. :-)
    >
    >
    > > --- a/drivers/base/power/sysfs.c 2008-01-04 16:50:54.000000000 +0800
    > > +++ b/drivers/base/power/sysfs.c 2008-01-04 17:14:42.000000000 +0800
    > > @@ -49,7 +49,7 @@ wake_show(struct device * dev, struct de
    > > {
    > > return sprintf(buf, "%s\n", device_can_wakeup(dev)
    > > ? (device_may_wakeup(dev) ? enabled : disabled)
    > > - : "");
    > > + : "unsupported");
    > > }
    > >
    > > static ssize_t
    > >
    > >



    \
     
     \ /
      Last update: 2008-01-07 02:59    [W:0.022 / U:29.384 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site