Messages in this thread |  | | | Subject | Re: [linux-pm][PATCH] base: Change power/wakeup output from "" to "unsupported" if wakeup feature isn't supported by a device | | From | Yi Yang <> | | Date | Mon, 07 Jan 2008 09:21:59 +0800 |
| |
On Fri, 2008-01-04 at 12:48 +0100, Pavel Machek wrote: > Hi! > > > If a device can't support wakeup, its /sys/devices/.../power/wakeup output is > > empty, this is confusing, a user doesn't know if it supports wakeup feature > > unless he/she read the ralated source code, for this case, it is more > > reasonable to output "unsupported". Otherwise, no matter what value the user > > sets to /sys/devices/.../power/wakeup, the result is the same: Invalid argument, > > so the user doesn't know why. > > > > This patch changes empty output to "unsupported" in order that a user knows > > wakeup feature isn't supported by this device when he/she > > 'cat /sys/devices/.../power/wakeup', please consider to apply, > > thanks. > > What about simply removing "wakuep" file if wakeup is not supported? > Pavel At the beginning, i did that as you said, but it can't work, some power/wakeup will disappear although they can be disabled or enabled, so it is only one feasible way to make it exist permanently. >
|  |