lkml.org 
[lkml]   [2008]   [Jan]   [6]   [last100]   RSS Feed
Views: [more markup]  [less markup]  [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH][RFC] Simple tamper-proof device filesystem.
FromTetsuo Handa <>
DateSun, 6 Jan 2008 16:36:06 +0900
Hello.

Willy Tarreau wrote:
> Your patch is very confusing. In your description, as well as in the
> comments you talk about tmpfs, but your patch does not touch even one
> line of tmpfs and only changes ramfs. Even your variables and arguments
> refer to tmpfs. The Kconfig entry indicates that the feature depends
> on TMPFS too.
> 
> Judging from the following comment :
>   * Original tmpfs doesn't set ramfs_dir_inode_operations.setattr field.
> 
> I suspect that you confuse both filesystems.
>   - ramfs is in fs/ramfs and is always compiled in, you cannot disable it
>   - tmpfs is in mm/shmem.c and is optional. It also supports options that
>     ramfs does not (eg: size) and data may be swapped.
> 
> Please understand that I'm not discussing the usefulness of your patch,
> I'm just trying to avoid a huge confusion.

Oh, I thought the filesystem mounted by "mount -t tmpfs none /tmp" is "tmpfs"
and the source code of "tmpfs" is located in fs/ramfs directory.
So, I should write the description as "an extension to ramfs" rather than
"an extension to tmpfs".
I'll fix it in next posting.

Thank you.


\
 
 \ /
  Last update: 2008-01-06 08:39    [from the cache]
©2003-2008