lkml.org 
[lkml]   [2008]   [Jan]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [RESEND PATCH 02/10] ide-floppy: move ide-floppy struct and macro defs into its own header. While at it
    On Fri, Jan 04, 2008 at 11:49:09PM +0100, Bartlomiej Zolnierkiewicz wrote:
    >
    > Hi,
    Hi Bart,

    > Hmm, contrary to ide-cd.c case there doesn't seem to be a need currently for
    > moving code out of ide-floppy.c (and this patch series doesn't change that).
    ?, you mean this patch series _does_ change that, meaning it moves the struct
    defs into a header file. Do i get this correctly that we don't need the header
    file and the struct defs should remain in the .c file?

    > Besides it would be better to just remove some structs like it has been done
    > with i.e. struct atapi_capabilities_page in ide-cd.c case [1] because:

    [...]

    > typedefs are evil (exceptions are rare) and should die :)
    >

    i'm redoing them right now against ide-2.6.git and will post when ready. By the
    way, i have done some more cleanups in the meantime. Should i include them into
    this series or send them later?

    --
    Regards/Gruß,
    Boris.
    --
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2008-01-05 13:51    [W:7.467 / U:0.444 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site