Messages in this thread | | | From | Andi Kleen <> | Subject | Re: [PATCH x86] [4/16] Add /proc/irq/*/spurious to dump the spurious irq debugging state | Date | Fri, 4 Jan 2008 13:22:01 +0100 |
| |
ix it:
You mean the new line after local variables?
I never liked this rule. Newlines may make sense on very large functions, but on short functions they just obscure more. And I actually checked CodingStyle now and it says nothing about that. So please apply the patch anyways.
-Andi
> > +static int irq_spurious_read(char *page, char **start, off_t off, > > + int count, int *eof, void *data) > > +{ > > + struct irq_desc *d = &irq_desc[(long) data]; > > + return sprintf(page, "count %u\n" > > + "unhandled %u\n" > > Ingo >
| |