Messages in this thread | | | Date | Fri, 4 Jan 2008 11:48:18 +0100 | From | Heiko Carstens <> | Subject | Re: [patch 2/2] Add the end-of-trace marker and the module list to WARN_ON() |
| |
On Thu, Jan 03, 2008 at 10:27:28PM +0100, Arjan van de Ven wrote: > > Another issue is that, unlike oopses, WARN_ON() doesn't currently printk > the helpful "cut here" line, nor the "end of trace" marker. > Now that WARN_ON() is out of line, the size increase due to this is > minimal and it's worth adding. > > +static void print_oops_end_marker(void) > +{ > + init_oops_id(); > + printk(KERN_WARNING "---[ end trace %016llx ]---\n", > + (unsigned long long)oops_id); > +}
There is also lib/bug.c which prints the "cut here" line but not the "end of trace" line. Also it prints whatever it prints with a different printk level. Quite a few architectures use lib/bug.c also for WARN_ONs. Maybe all the code should be in one place so it doesn't diverge all the time?
| |