Messages in this thread |  | | | Date | Fri, 4 Jan 2008 08:41:49 +0100 | | From | Ingo Molnar <> | | Subject | Re: [patch 1/2] move WARN_ON() out of line | |
* Arjan van de Ven <arjan@linux.intel.com> wrote:
> This patch build on top of Olof's patch that introduces __WARN, and
> places the slowpath out of line. It also uses Ingo's suggestion to not
> use __FUNCTION__ but to use kallsyms to do the lookup; this saves a
> ton of extra space since gcc doesn't need to store the function string
> twice now:
>
> 3936367 833603 624736 5394706 525112 vmlinux.before
> 3917508 833603 624736 5375847 520767 vmlinux-slowpath
>
> 15Kb savings...
hey, cool!
Acked-by: Ingo Molnar <mingo@elte.hu>
i'm wondering how we could put this into x86.git to get it tested some
more. Olof's patch touches other architectures so it's not really
appropriate. Maybe a portion of Olof's patch could be applied to make
your patch apply cleanly?
Ingo
|  |