lkml.org 
[lkml]   [2008]   [Jan]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    SubjectRe: [patch 1/3] move WARN_ON() out of line
    Date
    Arjan van de Ven <arjan@linux.intel.com> wrote:
    >
    >> While we're here, I'll mention that dump_stack probably ought to take a
    >> severity level argument.
    >
    > 125 files changed, 202 insertions(+), 199 deletions(-)
    > just to get the api change done.
    > I can hear akpm cringe from here...

    You don't have to change all of them at once. Just create a new function
    that does take a level and make the old dump_stack and WARN_ON call that
    then slowly convert everything else across if so desired.

    Cheers,
    --
    Visit Openswan at http://www.openswan.org/
    Email: Herbert Xu ~{PmV>HI~} <herbert@gondor.apana.org.au>
    Home Page: http://gondor.apana.org.au/~herbert/
    PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt


    \
     
     \ /
      Last update: 2008-01-05 03:39    [W:3.516 / U:0.136 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site