Messages in this thread | | | From | David Brownell <> | Subject | Re: [linux-pm] sleepy linux self-test | Date | Thu, 31 Jan 2008 17:55:33 -0800 |
| |
On Wednesday 30 January 2008, Pavel Machek wrote:
> --- a/drivers/rtc/rtc-cmos.c > +++ b/drivers/rtc/rtc-cmos.c > @@ -78,7 +78,7 @@ static inline int is_intr(u8 rtc_intr) > > /*----------------------------------------------------------------*/ > > -static int cmos_read_time(struct device *dev, struct rtc_time *t) > +int cmos_read_time(struct device *dev, struct rtc_time *t) > { > > ... etc ...
You should be using the standard RTC library calls, exported from drivers/rtc/interface.c ... and making sure this mechanism will work with any wakeup-capable RTC. Otherwise you'll end being needlessly x86-specific, or reinventing those calls.
Plus, the way you're doing it now is violating the locking protocol used by that driver.
- Dave
| |