Messages in this thread | | | Date | Wed, 30 Jan 2008 19:29:39 -0800 | From | Yinghai Lu <> | Subject | Re: PATCH] x86_64: make bootmap_start page align v4 |
| |
On Wednesday 30 January 2008 07:02:14 pm Andi Kleen wrote: > > > I don't think so, that is setup_node_bootmem's problem. > > > > it is supposed to round_up instead of just do PAGE_SHIFT... > > > > other caller will just use the address instead change it page. > > You're right. In this case it really is the best way to round up in the > caller. I retract my earlier objection. > > That said there is not really any true requirement for the bootmem > map to be page aligned (AFAIK) so an alternative might be to > fix the bootmem interface to not take a PFN. But that would be a > much more intrusive patch because you would need to fix > other architectures too or add compat wrappers.
thanks.
So we need to v4.
Ingo,
can you apply the v4?
YH
| |