lkml.org 
[lkml]   [2008]   [Jan]   [30]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: arch/x86/kernel/test_nx.c compile error

    * Adrian Bunk <bunk@kernel.org> wrote:

    > > +#ifdef CONFIG_X86_32
    > > + " .long 0b\n"
    > > + " .long 2b\n"
    > > +#endif
    > > " .quad 0b\n"
    > > " .quad 2b\n"
    > > +#else
    > >...
    >
    > You don't test whether your patches compile? ;-)

    i did - but i didnt test whether i sent you the right, fixed one :-)

    > After the obvious fix it compiled.
    >
    > Why wasn't this issue found before it entered Linus' tree?

    because it was a relatively late patch and TEST_NX is dependent on a
    modular build - which i dont test that often. I found and fixed a mirror
    image bug in test_rodata.c.

    Ingo


    \
     
     \ /
      Last update: 2008-01-30 20:13    [W:5.783 / U:0.636 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site