Messages in this thread | | | Date | Wed, 30 Jan 2008 21:00:04 +0200 | From | Adrian Bunk <> | Subject | Re: arch/x86/kernel/test_nx.c compile error |
| |
On Wed, Jan 30, 2008 at 07:44:32PM +0100, Ingo Molnar wrote: > > * Ingo Molnar <mingo@elte.hu> wrote: > > > does the patch below help? > > uhm, the one below instead. > > Ingo > > ------------> > Subject: x86: fix arch/x86/kernel/test_nx.c modular build bug > From: Ingo Molnar <mingo@elte.hu> > > fix this modular build bug: > > > CC [M] arch/x86/kernel/test_nx.o > > {standard input}: Assembler messages: > > {standard input}:58: Error: cannot represent relocation type BFD_RELOC_64 > > {standard input}:59: Error: cannot represent relocation type BFD_RELOC_64 > > make[2]: *** [arch/x86/kernel/test_nx.o] Error 1 > > make[1]: *** [arch/x86/kernel] Error 2 > > Reported-by: Adrian Bunk <bunk@kernel.org> > Signed-off-by: Ingo Molnar <mingo@elte.hu> > --- > arch/x86/kernel/test_nx.c | 5 +++++ > 1 file changed, 5 insertions(+) > > Index: linux-x86.q/arch/x86/kernel/test_nx.c > =================================================================== > --- linux-x86.q.orig/arch/x86/kernel/test_nx.c > +++ linux-x86.q/arch/x86/kernel/test_nx.c > @@ -91,8 +91,13 @@ static noinline int test_address(void *a > ".previous\n" > ".section __ex_table,\"a\"\n" > " .align 8\n" > +#ifdef CONFIG_X86_32 > + " .long 0b\n" > + " .long 2b\n" > +#endif > " .quad 0b\n" > " .quad 2b\n" > +#else >...
You don't test whether your patches compile? ;-)
After the obvious fix it compiled.
Why wasn't this issue found before it entered Linus' tree?
cu Adrian
--
"Is there not promise of rain?" Ling Tan asked suddenly out of the darkness. There had been need of rain for many days. "Only a promise," Lao Er said. Pearl S. Buck - Dragon Seed
| |