lkml.org 
[lkml]   [2008]   [Jan]   [30]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 1/1] [Blackfin] char driver for Blackfin on-chip OTP memory
    On 01/30/2008 02:19 PM, Mike Frysinger wrote:
    > On Jan 30, 2008 6:00 AM, Jiri Slaby <jirislaby@gmail.com> wrote:
    >> On 01/30/2008 11:36 AM, Bryan Wu wrote:
    >>> + ret = cdev_add(&bfin_otp_cdev, bfin_otp_dev_node, 1);
    >>> + if (ret) {
    >>> + unregister_chrdev_region(bfin_otp_dev_node, 1);
    >>> + printk(KERN_ERR PFX "unable to register char device\n");
    >>> + return ret;
    >>> + }
    >>> +
    >>> + bfin_otp_class = class_create(THIS_MODULE, "otp");
    >>> + device_create(bfin_otp_class, NULL, bfin_otp_dev_node, "otp");
    >> Anyway, wouldn't be easier/better to use misc.c functionality here
    >> (misc_register() et al.)?
    >
    > probably ... i just didnt want to statically allocate a number in the
    > range that would be Blackfin specific ...

    MISC_DYNAMIC_MINOR is definitely your friend ;).



    \
     
     \ /
      Last update: 2008-01-30 14:41    [W:0.040 / U:4.864 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site