Messages in this thread | | | Date | Wed, 30 Jan 2008 12:25:59 +0100 | From | Sam Ravnborg <> | Subject | Re: [PATCH] [SIS190] Constify data marked as __devinitdata |
| |
On Wed, Jan 30, 2008 at 12:23:23PM +0100, Jan Engelhardt wrote: > > On Jan 30 2008 11:53, Jonas Bonn wrote: > > > >This fixes build error as gcc complains about a "section type conflict" > >due to the const __devinitdata in sis190_get_mac_addr_from_apc(). > > >-static struct pci_device_id sis190_pci_tbl[] __devinitdata = { > >+static const struct pci_device_id sis190_pci_tbl[] __devinitdata = { > > { PCI_DEVICE(PCI_VENDOR_ID_SI, 0x0190), 0, 0, 0 }, > > { PCI_DEVICE(PCI_VENDOR_ID_SI, 0x0191), 0, 0, 1 }, > > { 0, }, > > Eh? Did you mean to > > - static const u16 __devinitdata ids[] = { 0x0965, 0x0966, 0x0968 }; > + static u16 __devinitdata ids[] = { 0x0965, 0x0966, 0x0968 }; > > instead? Because AFAIK, const *and* __sectionmarker does not mix.
We have just introduced __initconst, __cpuinitconst, __meminitconst for const data. So the patch is wrong.
Sam
| |