lkml.org 
[lkml]   [2008]   [Jan]   [3]   [last100]   RSS Feed
Views: [more markup]  [less markup]  [headers]  [forward] 
 
Messages in this thread
/
DateThu, 3 Jan 2008 10:54:52 +0100
FromIngo Molnar <>
SubjectRe: [PATCH] [1/20] x86: Make ptrace.h safe to include from assembler code
* Andi Kleen <ak@suse.de> wrote:

> Index: linux/include/asm-x86/ptrace-abi.h
> ===================================================================
> --- linux.orig/include/asm-x86/ptrace-abi.h
> +++ linux/include/asm-x86/ptrace-abi.h
> @@ -80,6 +80,7 @@
> 
>  #define PTRACE_SINGLEBLOCK	33	/* resume execution until next branch */
> 
> +#ifndef __ASSEMBLY__

hm, this patch misses a rationale - what assembly code includes 
ptrace-abi.h directly or indirectly? Did you see any build breakage with 
x86.git that requires this? (if yes then please send me the .config)

	Ingo


\
 
 \ /
  Last update: 2008-01-03 10:57    [from the cache]
©2003-2008