lkml.org 
[lkml]   [2008]   [Jan]   [3]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [GIT] More NFS client fixes for 2.6.24-rc6

* Trond Myklebust <Trond.Myklebust@netapp.com> wrote:

> commit 53478daff2c8b494d2af1ede6611f166f81bc393
> Author: Trond Myklebust <Trond.Myklebust@netapp.com>
> Date: Wed Jan 2 13:28:57 2008 -0500
>
> NFS: Fix a possible Oops in fs/nfs/super.c
>
> Sigh... commit 4584f520e1f773082ef44ff4f8969a5d992b16ec (NFS: Fix NFS
> mountpoint crossing...) had a slight flaw: server can be NULL if sget()
> returned an existing superblock.
>
> Fix the fix by dereferencing s->s_fs_info.
>
> Also add in the same namespace Oops fix for NFSv4 in both the mountpoint
> crossing case, and the referral case.
>
> Signed-off-by: Trond Myklebust <Trond.Myklebust@netapp.com>

shouldnt this commit have included the full credit of the bugfix:

http://bugzilla.kernel.org/show_bug.cgi?id=9647

------------>
Description From Adrian Bunk 2007-12-27 12:36

The Coverity checker spotted that commit
4584f520e1f773082ef44ff4f8969a5d992b16ec introduced the following NULL
dereference in 2.6.24-rc6:

<-- snip -->
if (s->s_fs_info != server) {
nfs_free_server(server);
server = NULL; <---------------
}

------- Comment #1 From Adrian Bunk 2007-12-27 12:37:42 -------
The NULL dereference is at the
server->nfs_client->rpc_ops->dir_inode_ops.
<--------------

Ingo


\
 
 \ /
  Last update: 2008-01-03 10:33    [W:0.072 / U:0.096 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site