Messages in this thread | | | From | Neil Brown <> | Date | Fri, 4 Jan 2008 11:41:55 +1100 | Subject | Re: [PATCH] md: Fix data corruption when a degraded raid5 array is reshaped. |
| |
On Thursday January 3, dan.j.williams@intel.com wrote: > > On closer look the safer test is: > > !test_bit(STRIPE_OP_COMPUTE_BLK, &sh->ops.pending). > > The 'req_compute' field only indicates that a 'compute_block' operation > was requested during this pass through handle_stripe so that we can > issue a linked chain of asynchronous operations. > > --- > > From: Neil Brown <neilb@suse.de>
Technically that should probably be From: Dan Williams <dan.j.williams@intel.com>
now, and then I add Acked-by: NeilBrown <neilb@suse.de>
because I completely agree with your improvement.
We should keep an eye out for then Andrew commits this and make sure the right patch goes in...
Thanks, NeilBrown
| |