Messages in this thread | | | Date | Thu, 3 Jan 2008 18:11:27 -0500 | From | Rik van Riel <> | Subject | Re: [GIT PULL] please pull infiniband.git for-linus |
| |
On Thu, 03 Jan 2008 15:20:09 -0500 David Dillow <dillowda@ornl.gov> wrote:
> diff --git a/drivers/infiniband/ulp/srp/ib_srp.c b/drivers/infiniband/ulp/srp/ib_srp.c > index 950228f..6e7e3c8 100644 > --- a/drivers/infiniband/ulp/srp/ib_srp.c > +++ b/drivers/infiniband/ulp/srp/ib_srp.c > @@ -423,8 +423,8 @@ static void srp_remove_work(struct work_struct *work) > list_del(&target->list); > spin_unlock(&target->srp_host->target_lock); > > - srp_remove_host(target->scsi_host); > scsi_remove_host(target->scsi_host); > + srp_remove_host(target->scsi_host); > ib_destroy_cm_id(target->cm_id); > srp_free_target_ib(target); > scsi_host_put(target->scsi_host);
These last two look suspicious. Are you freeing target before freeing target->scsi_host or does the code simply not do what it looks like it's doing? :)
(no, I haven't looked at the IB code - I'm probably wrong)
-- All Rights Reversed
| |