lkml.org 
[lkml]   [2008]   [Jan]   [3]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [x86] kernel/audit.c cleanup according to checkpatch.pl
    [David Woodhouse - Thu, Jan 03, 2008 at 02:37:24PM +0000]
    |
    | On Thu, 2008-01-03 at 15:37 +0100, Ingo Molnar wrote:
    | > * David Woodhouse <dwmw2@infradead.org> wrote:
    | >
    | > > On Thu, 2008-01-03 at 15:05 +0100, Ingo Molnar wrote:
    | > > > not to make a big issue out of this, but when was the last time you
    | > > > tried to grep this way:
    | > > >
    | > > > grep -E "audit_rate_limit=[0-9]+ audit_backlog" */*.c
    | > >
    | > > Not precisely that, but I've certainly had greps fail because people
    | > > have split up strings to meet the stupid 80-character "limit".
    | >
    | > yes - but if you read my whole reply you'll see that i qualified it:
    | >
    | > >> That's pretty much the only grep pattern that would break. People
    | > >> usually grep on the constant portion of the string, so breaking up a
    | > >> ^^^^^^^^^^^^^
    | > >> line along a variable boundary is perfectly okay.
    |
    | Yes, you did. But you failed to provide any good reason for actually
    | changing it, either. Leave it as it was.
    |
    | --
    | dwmw2
    |

    so what i would do now? i could post updated patch *without* that
    splitted line, should I?

    - Cyrill -


    \
     
     \ /
      Last update: 2008-01-03 15:53    [W:0.065 / U:116.660 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site