lkml.org 
[lkml]   [2008]   [Jan]   [3]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    SubjectRe: [PATCH] [20/20] x86: Print which shared library/executable faulted in segfault etc. messages
    Date

    > > And printing the offset into a mapping also always allows to find the
    > > correct fault point in a library even with randomized mappings. Previously
    > > there was no way to actually find the correct code address inside
    > > the randomized mapping.
    > >
    > > Relies on earlier patch to shorten the printk formats.
    > >
    > > They are often now longer than 80 characters, but I think that's worth
    > > it.
    >
    > why not make it multi-line? that way the %lx hack wouldnt be needed
    > either.

    I prefer it single-line. I also disagree on %lx being a hack.

    >
    > > +void print_vma_addr(char *prefix, unsigned long ip)
    > > +{
    > > + struct mm_struct *mm = current->mm;
    > > + struct vm_area_struct *vma;
    > > + down_read(&mm->mmap_sem);
    > > + vma = find_vma(mm, ip);
    >
    > grumble. Proper CodingStyle please.


    Looks fine to me. If you mean the new line after variables -- that was always optional.

    Anyways I'll repost with the error check.

    Also it seems like you did apply only parts of the patchkit. If you do that can
    you send a list of what patches you didn't add, otherwise it'll be messy to figure
    this out from here.

    -Andi


    \
     
     \ /
      Last update: 2008-01-03 14:11    [W:0.022 / U:30.456 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site