lkml.org 
[lkml]   [2008]   [Jan]   [29]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [patch 2/6] mmu_notifier: Callbacks to invalidate address ranges
    On Tue, 29 Jan 2008, Andrea Arcangeli wrote:

    > > + mmu_notifier(invalidate_range, mm, address,
    > > + address + PAGE_SIZE - 1, 0);
    > > page_table = pte_offset_map_lock(mm, pmd, address, &ptl);
    > > if (likely(pte_same(*page_table, orig_pte))) {
    > > if (old_page) {
    >
    > What's the point of invalidate_range when the size is PAGE_SIZE? And
    > how can it be right to invalidate_range _before_ ptep_clear_flush?

    I am not sure. AFAICT you wrote that code.

    It seems to be okay to invalidate range if you hold mmap_sem writably. In
    that case no additional faults can happen that would create new ptes.





    \
     
     \ /
      Last update: 2008-01-29 20:57    [W:0.021 / U:88.920 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site