Messages in this thread | | | Date | Tue, 29 Jan 2008 11:49:07 -0800 (PST) | From | Christoph Lameter <> | Subject | Re: [patch 1/6] mmu_notifier: Core code |
| |
On Tue, 29 Jan 2008, Andrea Arcangeli wrote:
> > + struct mmu_notifier_head mmu_notifier; /* MMU notifier list */ > > }; > > Not sure why you prefer to waste ram when MMU_NOTIFIER=n, this is a > regression (a minor one though).
Andrew does not like #ifdefs and it makes it possible to verify calling conventions if !CONFIG_MMU_NOTIFIER.
> It's out of my reach how can you be ok with lock=1. You said you have > to block, if you can deal with lock=1 once, why can't you deal with > lock=1 _always_?
Not sure yet. We may have to do more in that area. Need to have feedback from Robin.
| |